Merge lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

[Notabilis]

Fixing broken auto-scrolling of multi-line text areas.

Seems to be a case of wrong direction of comparison. I would appreciate it if someone thinks about it for a moment before merging.

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 3776. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/415148977.
Appveyor build 3575. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1785404_chat_scrolling-3575.

[Toni Förster (stonerl)]

Works for me. Tested on macOS 10.13.

review: Approve

[GunChleoc (gunchleoc)]

Code LGTM :)

review: Approve

[GunChleoc (gunchleoc)]

@bunnybot merge

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 3786. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415538286.
Appveyor build 3585. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1785404_chat_scrolling-3585.

=== modified file 'src/ui_basic/multilinetextarea.cc'
--- src/ui_basic/multilinetextarea.cc	2018-07-28 07:02:25 +0000
+++ src/ui_basic/multilinetextarea.cc	2018-08-13 16:00:23 +0000
@@ -104,7 +104,7 @@
 		scrollbar_.set_steps(height - get_h());
 
 		if (scrollmode_ == ScrollMode::kScrollLog || scrollmode_ == ScrollMode::kScrollLogForced) {
-			if (scrollbar_.get_scrollpos() >= scrollbar_.get_steps() - 1) {
+			if (scrollbar_.get_scrollpos() < scrollbar_.get_steps() - 1) {
 				scrollbar_.set_scrollpos(height - get_h());
 			}
 		}