Code review comment for lp:~widelands-dev/widelands/bug-1776008-boost-deleted-uuid-function

Revision history for this message
kaputtnik (franku) wrote :

Compiling works fine :-) (beside the known issues)

Here are the values of your quick test:

Old values:
uuid="3436e035-dc2e-46b8-ac1f-7487343547e6"
last_start="1528746135"

After deleting last_start:
uuid="a9f6baf2-04c9-4588-9bbd-7c42e83eb1e6"
last_start="1528746335"

After deleting uuid:
uuid="93113199-e1b7-47e2-9d49-6f21be977be9"
last_start="1528746469"

After deleting both:
uuid="8fb0f3f7-1109-4c85-bed2-c049e043e909"
last_start="1528746596"

Did also run the regression tests (no idea if this is importand :-D ):

> Ran 42 tests in 513.259s
> OK

From my side all fine now.

review: Approve (testing)

« Back to merge proposal