Code review comment for lp:~widelands-dev/widelands/bug-1759857-territorial-lord

Revision history for this message
Notabilis (notabilis27) wrote :

I wasn't able to reproduce the reported bug but it didn't crashed in my tests either. However, the final lost/won message is broken, since the land ownership is reported as:

Player 1 had 179000% of the land (3580 of 2).

Unfortunately I wasn't able to spot the error. It seems as if the local variable fields changes its value but I have no idea how that should happen. Apart from that, it worked without problems and the earlier status messages were correct as well.

I also looked roughly through the code and haven't noticed any obvious mistakes, but that doesn't mean much.

review: Needs Fixing (testing)

« Back to merge proposal