Merge lp:~widelands-dev/widelands/bug-1743086-sdl-sound-bug-workaround into lp:widelands
Proposed by
Klaus Halfmann
Status: | Merged |
---|---|
Merged at revision: | 8662 |
Proposed branch: | lp:~widelands-dev/widelands/bug-1743086-sdl-sound-bug-workaround |
Merge into: | lp:widelands |
Diff against target: |
281 lines (+85/-31) 4 files modified
src/sound/sound_handler.cc (+42/-11) src/sound/sound_handler.h (+7/-6) src/ui_fsmenu/options.cc (+9/-2) src/wui/game_options_sound_menu.cc (+27/-12) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug-1743086-sdl-sound-bug-workaround |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Widelands Developers | Pending | ||
Review via email: mp+343764@code.launchpad.net |
Commit message
Workaround for Bug 1743086, completly disable sound in this case.
Test this on "Linux Budgie 4.13.0-38-generic #43-Ubuntu SMP Wed Mar 14 15:20:44 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux" works as expected
Description of the change
Actually Done by GunChleoc:
Set a special flag that completly disables any sound, despite any user settigns, adds some log- and warning- messages to inform the User about this.
To post a comment you must log in.
Continuous integration builds have changed state:
Travis build 3397. State: passed. Details: https:/ /travis- ci.org/ widelands/ widelands/ builds/ 369740569. /ci.appveyor. com/project/ widelands- dev/widelands/ build/_ widelands_ dev_widelands_ bug_1743086_ sdl_sound_ bug_workaround- 3203.
Appveyor build 3203. State: success. Details: https:/