widelands

Merge lp:~widelands-dev/widelands/bug-1733212-game-information-update-fails into lp:widelands

  1. bug-1733212-game-information-update-fails
  2. Merge into trunk
Proposed by GunChleoc
Status: Merged
Merged at revision: 8537
Proposed branch: lp:~widelands-dev/widelands/bug-1733212-game-information-update-fails
Merge into: lp:widelands
Diff against target: 12 lines (+1/-1)
1 file modified
src/ui_basic/table.cc (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug-1733212-game-information-update-fails
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+335305@code.launchpad.net

Commit message

Fixed bug where table didn't sent selected() signal during multiselect

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

@bunnybot merge

review: Approve
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 2984. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/317987997.
Appveyor build 2793. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1733212_game_information_update_fails-2793.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ui_basic/table.cc'
2--- src/ui_basic/table.cc 2017-11-06 20:19:56 +0000
3+++ src/ui_basic/table.cc 2017-12-18 08:48:04 +0000
4@@ -426,7 +426,7 @@
5 * Args: i the entry to select
6 */
7 void Table<void*>::select(const uint32_t i) {
8- if (empty() || selection_ == i || i == no_selection_index())
9+ if (empty() || i == no_selection_index())
10 return;
11
12 selection_ = i;

Subscribers

People subscribed via source and target branches

to status/vote changes: