Merge lp:~widelands-dev/widelands/bug-1658668-sp-ai into lp:widelands

[GunChleoc]

Do not change the AI settings when toggling single player slots on/off.

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 3546. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/384036458.
Appveyor build 3350. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1658668_sp_ai-3350.

[Notabilis (notabilis27)]

Diff looks good and bug is fixed.

review: Approve (diff, testing)

[GunChleoc (gunchleoc)]

Thanks for the review :)

@bunnybot merge

=== modified file 'src/wui/playerdescrgroup.cc'
--- src/wui/playerdescrgroup.cc	2018-04-27 06:11:05 +0000
+++ src/wui/playerdescrgroup.cc	2018-05-26 08:56:33 +0000
@@ -214,11 +214,13 @@
 		return;
 
 	if (on) {
-		if (settings.players[d->plnum].state == PlayerSettings::State::kClosed)
-			d->settings->next_player_state(d->plnum);
+		if (settings.players[d->plnum].state == PlayerSettings::State::kClosed) {
+			d->settings->set_player_state(d->plnum, PlayerSettings::State::kComputer);
+		}
 	} else {
-		if (settings.players[d->plnum].state != PlayerSettings::State::kClosed)
+		if (settings.players[d->plnum].state != PlayerSettings::State::kClosed) {
 			d->settings->set_player_state(d->plnum, PlayerSettings::State::kClosed);
+		}
 	}
 }