Merge lp:~widelands-dev/widelands/bug-1656245-scrollbar-mousewheel into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8719
Proposed branch: lp:~widelands-dev/widelands/bug-1656245-scrollbar-mousewheel
Merge into: lp:widelands
Diff against target: 11 lines (+1/-0)
1 file modified
src/ui_basic/listselect.cc (+1/-0)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug-1656245-scrollbar-mousewheel
Reviewer Review Type Date Requested Status
Notabilis Approve
Review via email: mp+346445@code.launchpad.net

Commit message

Fix mousewheel speed for listselect

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 3536. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/382035769.
Appveyor build 3340. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1656245_scrollbar_mousewheel-3340.

Revision history for this message
Notabilis (notabilis27) wrote :

Works good, the lists are scrolling as they should.

review: Approve
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for the review :)

@bunnybot merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ui_basic/listselect.cc'
2--- src/ui_basic/listselect.cc 2018-05-13 07:15:39 +0000
3+++ src/ui_basic/listselect.cc 2018-05-22 07:29:28 +0000
4@@ -286,6 +286,7 @@
5 scrollbar_.set_size(scrollbar_.get_w(), get_h());
6 scrollbar_.set_pos(Vector2i(get_w() - Scrollbar::kSize, 0));
7 scrollbar_.set_pagesize(get_h() - 2 * get_lineheight());
8+ scrollbar_.set_singlestepsize(get_lineheight());
9 const int steps = entry_records_.size() * get_lineheight() - get_h();
10 scrollbar_.set_steps(steps);
11 if (scrollbar_.is_enabled() && selection_mode_ == ListselectLayout::kDropdown) {

Subscribers

People subscribed via source and target branches

to status/vote changes: