Code review comment for lp:~widelands-dev/widelands/bug-1645844-game-summary

Revision history for this message
Notabilis (notabilis27) wrote :

Thanks, the dash is much better than displaying it as team 0.
Testing worked fine and code change is looking good.

Small refactoring suggestion for the existing code: Rename the local variable teastr_ to team_str. No idea why it was named that way, it is another naming scheme than the other local variables and seems to denote a private member variable.

review: Approve

« Back to merge proposal