Code review comment for lp:~widelands-dev/widelands/bug-1636586-editor-player-menu-i18n

Revision history for this message
Notabilis (notabilis27) wrote :

Not tested but code is looking good.
One question: Why checking for both the localized and "plain" name variant when saving? In English they should resolve to the same name anyway (right?) and I don't see where the plain version can appear otherwise.

review: Approve (diff)

« Back to merge proposal