Code review comment for lp:~widelands-dev/widelands/bug-1588063
Revision history for this message
| Klaus Halfmann (klaus-halfmann) wrote | # |
review:
Approve
(compile, review, test)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
OK, Tested some "evil" charaters. On OSX '`´&$()[]{} are allowed while |/":* are not (incomplete).
Maybe we should filter these as well, to avoid Filenames with bad effects on the Commandline?
OTOH the average user will not not use such characters, will he/she?
Code LGTM, but I can test OSX only, so we need some Windows test, too.