widelands

Code review comment for lp:~widelands-dev/widelands/bug-1573968-new-map-crash

  1. bug-1573968-new-map-crash
  2. Merge into trunk
Revision history for this message
Miroslav Remák (miroslavr256) wrote :

I think selecting info tool in EditorInteractive::cleanup_for_load is unnecessary and does not fix the problem at its root. I propose:
 - changing 'current_player_ = 0;' to 'current_player_ = 1;' in EditorSetStartingPosTool's constructor
 - replacing 'select_tool(tools()->info, EditorTool::First);' with 'mutable_field_overlay_manager()->register_overlay_callback_function(nullptr);' in EditorInteractive::cleanup_for_load

« Back to merge proposal