Code review comment for lp:~widelands-dev/widelands/bug-1560454-mapdir

Revision history for this message
GunChleoc (gunchleoc) wrote :

> > - Show full save path to user
> This shows the wrong path. Here it is shown: /home/kaputtnik/widelands-
> repo/bug-1560454-mapdir/maps/My_Maps
> Instead the map is saved in: /home/kaputtnik/.widelands/maps/My_Maps

I'll look into this.

> > - After creating a new directory, enter it
> Good idea :-) But it confuses a bit, because one couldn't see which folder is
> currently shown.

I'll remove this feature then

> > - Automatically focus map name editbox when creating new map
> I couldn't find this feature :-S Either it is not working or i do not
> understand it.

Sorry, I meant create directory, not create map.

> It is not possible anymore to store a map in a folder which was created prior
> this changes, because i couldn't go to the "previous folder". So my maps
> stored in folder ~/.widelands/maps/test/ could be loaded, but not saved in
> this folder anymore. One has to move the previous folders he created in
> ~/.widelands/maps into ~/.widelands/maps/My_Maps/ to save his own maps in his
> own folders again. Same goes for maps which are stored in ~/.widelands/maps/

Yes, they will have to be moved. Which is why I came up with the idea of displaying the full directory, so the user can go find the maps on their computer and fix.

> As mentioned in the bug report i would like to see the "Shipped maps" in a sub
> folder in menu "Load map" where the shipped maps could be found. In menu "Save
> map" this folder shouldn't be shown then. I believe this would be the better
> approach. Isn't that possible?

And how would this look when creating a new game then? All users, even those who don't have any own maps, will have to enter a "Shipped Maps" subfolder every time in order to start a new game?

« Back to merge proposal