Code review comment for lp:~widelands-dev/widelands/bug-1560454-mapdir

Revision history for this message
kaputtnik (franku) wrote :

> - Show full save path to user
This shows the wrong path. Here it is shown: /home/kaputtnik/widelands-repo/bug-1560454-mapdir/maps/My_Maps
Instead the map is saved in: /home/kaputtnik/.widelands/maps/My_Maps

> - After creating a new directory, enter it
Good idea :-) But it confuses a bit, because one couldn't see which folder is currently shown.

> - Automatically focus map name editbox when creating new map
I couldn't find this feature :-S Either it is not working or i do not understand it. If i create a new map nothing is shown to edit the name of the map. And if i want to save the map, the focus is always on the map, not in the menu (f.e. hitting "f" toggles Fullscreen). If i first choose the map options menu, there is also no focus on the map name edit box.

It is not possible anymore to store a map in a folder which was created prior this changes, because i couldn't go to the "previous folder". So my maps stored in folder ~/.widelands/maps/test/ could be loaded, but not saved in this folder anymore. One has to move the previous folders he created in ~/.widelands/maps into ~/.widelands/maps/My_Maps/ to save his own maps in his own folders again. Same goes for maps which are stored in ~/.widelands/maps/

As mentioned in the bug report i would like to see the "Shipped maps" in a sub folder in menu "Load map" where the shipped maps could be found. In menu "Save map" this folder shouldn't be shown then. I believe this would be the better approach. Isn't that possible?

Needs fixing because of "Show full path to the user".

review: Needs Fixing

« Back to merge proposal