Code review comment for lp:~widelands-dev/widelands/bug-1559729-lost_portspace

I see in fact two issues here, but I am not that far working on that:

a) is_port_space(f) - it seems there is something broken with this, it says false, even though should say true

b) portdock - the issue here is that if a port is build there and is not able to establish a portdock, it will crash the game. Unless the port expands a territory a bit...

I thinks we should fix "a)" item

There is a code:

if ((buildsize == BaseImmovable::BIG) && is_port_space(f) && !find_portdock(f).empty())

and in this case is_port_space(f) should return true and !find_portdock(f).empty() should return false, until the player conquers some sea area

My opinion