Merge lp:~widelands-dev/widelands/bug-1546810-undo-redo into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 7847
Proposed branch: lp:~widelands-dev/widelands/bug-1546810-undo-redo
Merge into: lp:widelands
Diff against target: 12 lines (+1/-1)
1 file modified
src/editor/tools/editor_draw_tool.h (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug-1546810-undo-redo
Reviewer Review Type Date Requested Status
SirVer Approve
kaputtnik (community) testing Approve
Review via email: mp+286733@code.launchpad.net

Commit message

Fixed undo/redo bug when drawing terrains in the editor.

Description of the change

Fixed undo/redo bug when drawing terrains in the editor.

To post a comment you must log in.
Revision history for this message
kaputtnik (franku) wrote :

Works perfect again :-)

review: Approve (testing)
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 739. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/110576262.
Appveyor build 585. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1546810_undo_redo-585.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for testing! The code change is trivial, so I'm gonna merge.

@bunnybot merge

Revision history for this message
SirVer (sirver) wrote :

no idea what that string change does, frankly...

review: Approve
Revision history for this message
GunChleoc (gunchleoc) wrote :

Me neither, which is why I caused this bug in the first place *lol

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/editor/tools/editor_draw_tool.h'
2--- src/editor/tools/editor_draw_tool.h 2016-01-28 05:24:34 +0000
3+++ src/editor/tools/editor_draw_tool.h 2016-02-20 10:41:42 +0000
4@@ -43,7 +43,7 @@
5 EditorActionArgs format_args_impl(EditorInteractive & parent) override;
6
7 char const * get_sel_impl() const override {
8- return "images/ui_basic/fsel.png";
9+ return "EDITOR_DRAW_TOOL";
10 }
11
12 void add_action(EditorToolAction ac, EditorActionArgs & args);

Subscribers

People subscribed via source and target branches

to status/vote changes: