Merge lp:~widelands-dev/widelands/bug-1526911-cursor-positioning into lp:widelands
Proposed by
GunChleoc
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 7943 | ||||
Proposed branch: | lp:~widelands-dev/widelands/bug-1526911-cursor-positioning | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
81 lines (+18/-10) 4 files modified
src/editor/ui_menus/editor_player_menu.cc (+0/-4) src/map_io/map_player_names_and_tribes_packet.cc (+10/-1) src/ui_basic/editbox.cc (+5/-2) src/ui_basic/multilineeditbox.cc (+3/-3) |
||||
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug-1526911-cursor-positioning | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Miroslav Remák | code | Approve | |
kaputtnik (community) | testing | Approve | |
Review via email: mp+290954@code.launchpad.net |
Commit message
Some cursor fixes for edit boxes:
- Fixed cursor y position for empty Editboxes.
- Moved test for empty player names from editor player tool to map saving.
- In a new MultilineEditbox, position cursor at end of text.
Description of the change
Cursor position for BiDi languages is still broken, but that's a separate issue.
To post a comment you must log in.
Continuous integration builds have changed state:
Travis build 962. State: failed. Details: https:/ /travis- ci.org/ widelands/ widelands/ builds/ 120833342. /ci.appveyor. com/project/ widelands- dev/widelands/ build/_ widelands_ dev_widelands_ bug_1526911_ cursor_ positioning- 795.
Appveyor build 795. State: success. Details: https:/