Code review comment for lp:~widelands-dev/widelands/bug-1525706-artifacts

Revision history for this message
kaputtnik (franku) wrote :

Seems to work properly now :-)

I got one crash after several load/save actions in the editor, but i don't know if this is related to this branch or in general to bug 1543944. The crash happens after loading a map and the output says:

WidelandsMapLoader::load_map_complete() took 356ms
widelands: /home/kaputtnik/Quellcode/widelands-repo/bug-1525706-artifacts/src/logic/map.h:510: static Widelands::MapIndex Widelands::Map::get_index(const Widelands::Coords&, int16_t): Assertion `c.x < width' failed.
Abgebrochen (Speicherabzug geschrieben)

It would be nice if MapLoader and MapSaver also writes the name of the map to the output. It is hard to remember which map was saved/loaded when one often loads and saves much maps.

« Back to merge proposal