Code review comment for lp:~widelands-dev/widelands/bug-1392406

Revision history for this message
GunChleoc (gunchleoc) wrote :

The common code is:

if (get_key_state(SDL_SCANCODE_LCTRL) || get_key_state(SDL_SCANCODE_RCTRL)) {
    do_something_arbitrary();
} else {
   do_something_else_arbitrary();
}

There is an ActionConfirm object for Buildings and Ships.

For end_modal, we have 2 occurrences only: Here and in the game options window. There is no quick fix for making them the same, because the game options window needs m_gb.end_modal(0) and the editor needs end_modal(0) - they are different object types. So, the change would need to be bigger than I want to get into right now.

« Back to merge proposal