Merge lp:~widelands-dev/widelands/bug-1380286 into lp:widelands
Proposed by
TiborB
Status: | Merged |
---|---|
Merged at revision: | 7398 |
Proposed branch: | lp:~widelands-dev/widelands/bug-1380286 |
Merge into: | lp:widelands |
Diff against target: |
161 lines (+80/-9) 4 files modified
src/scripting/lua_map.cc (+54/-5) src/scripting/lua_map.h (+3/-1) test/maps/lua_testsuite.wmf/scripting/flag.lua (+22/-1) test/maps/lua_testsuite.wmf/scripting/game.lua (+1/-2) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug-1380286 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
SirVer | Approve | ||
TiborB | Needs Resubmitting | ||
Review via email:
|
Description of the change
Adding 3 functions for LUA for flag object to list roads, building (if any) and verify whether the flag is connected to any warehouse
To post a comment you must log in.
Can you please add some regression tests as well?
They should go in test/maps/ lua_testsuite. wmf/scripting/ flag.lua
You can run these tests directly without having to run the whole test suite:
./widelands --scenario= test/maps/ lua_testsuite. wmf
I have also spotted a NOCOM comment in the diff - please grep to make sure you have resolved these, unless they contain a codereview question.
Once this is done, I'll have a closer look :)