Code review comment for lp:~widelands-dev/widelands/bug-1358880-ship-statistics

Revision history for this message
GunChleoc (gunchleoc) wrote :

I have now fixed everything except maybe for this one:

- Memory leak with create_shipinfo

I thought I had caught that one already, but I have worked on the function just in case - it now returns a unique_ptr. That function had also produced a compiler warning which I fixed (yay for upgrading my Ubuntu). Do you have steps to reproduce the memory leak?

review: Needs Resubmitting

« Back to merge proposal