Code review comment for lp:~widelands-dev/widelands/bug-1343297_2

Revision history for this message
SirVer (sirver) wrote :

> what does the _t in TypeAndLevel_t mean? We also have some _s stuff in the typedefs.

The _t mymics standard naming conventions from C++: uint8_t (_t stands for type). I think it unwise to use this for user defined types as for me it symbolizes a standard type. _s I have no idea what it should stand for and I think we should use it.

> If we wish to move to 'using' anyway, maybe just skip the rule and clean them up?

Just add a simple rule that check that typedef is never used then?

« Back to merge proposal