Merge lp:~widelands-dev/widelands/barbarians2-starting-objective into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 7989
Proposed branch: lp:~widelands-dev/widelands/barbarians2-starting-objective
Merge into: lp:widelands
Diff against target: 67 lines (+30/-2)
2 files modified
data/campaigns/bar02.wmf/scripting/mission_thread.lua (+14/-2)
data/campaigns/bar02.wmf/scripting/texts.lua (+16/-0)
To merge this branch: bzr merge lp:~widelands-dev/widelands/barbarians2-starting-objective
Reviewer Review Type Date Requested Status
Miroslav Remák code, testing Approve
Review via email: mp+293546@code.launchpad.net

Commit message

Barbarian Campaign 2: Added an objective to the first message.

Description of the change

Some players find it confusing that the second Barbarian scenario has no instructions in the first message. So, I have added some. This also requires the player to expand to the east a bit, which will get them closer to the tracks.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1083. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/127258989.
Appveyor build 914. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_barbarians2_starting_objective-914.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Bunnybot encountered an error while working on this merge proposal:

The read operation timed out

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1083. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/127258989.
Appveyor build 914. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_barbarians2_starting_objective-914.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Bunnybot encountered an error while working on this merge proposal:

The read operation timed out

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1083. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/127258989.
Appveyor build 914. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_barbarians2_starting_objective-914.

Revision history for this message
Miroslav Remák (miroslavr256) wrote :

LGTM.

review: Approve (code, testing)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks!

@bunnybot merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/campaigns/bar02.wmf/scripting/mission_thread.lua'
2--- data/campaigns/bar02.wmf/scripting/mission_thread.lua 2016-01-28 05:24:34 +0000
3+++ data/campaigns/bar02.wmf/scripting/mission_thread.lua 2016-05-02 15:51:07 +0000
4@@ -38,7 +38,19 @@
5 wake_me(2000)
6 campaign_message_box(story_msg_1)
7
8- wake_me(120000)
9+ local o = add_campaign_objective(obj_build_basic_economy)
10+ while not check_for_buildings(p1, {
11+ barbarians_lumberjacks_hut = 1,
12+ barbarians_rangers_hut = 1,
13+ barbarians_quarry = 1,
14+ barbarians_wood_hardener = 1,
15+ }) do sleep(3413) end
16+ while not check_for_buildings(p1, {barbarians_sentry=1}, game.map:get_field(57,36):region(6)) do
17+ sleep(1500)
18+ end
19+ o.done = true
20+ sleep(3000)
21+
22 campaign_message_box(briefing_msg_1)
23 campaign_message_box(order_msg_1_small_food_economy)
24
25@@ -53,7 +65,7 @@
26 "barbarians_sentry",
27 }
28
29- local o = add_campaign_objective(obj_build_small_food_economy)
30+ o = add_campaign_objective(obj_build_small_food_economy)
31 while not check_for_buildings(p1, {
32 barbarians_fishers_hut = 1,
33 barbarians_hunters_hut = 1,
34
35=== modified file 'data/campaigns/bar02.wmf/scripting/texts.lua'
36--- data/campaigns/bar02.wmf/scripting/texts.lua 2016-01-28 05:24:34 +0000
37+++ data/campaigns/bar02.wmf/scripting/texts.lua 2016-05-02 15:51:07 +0000
38@@ -16,6 +16,21 @@
39 -- =======================================================================
40
41
42+obj_build_basic_economy = {
43+ name = "build_basic_food_economy",
44+ title = _"Build up a basic economy",
45+ number = 5,
46+ body = objective_text(_"Build up a basic economy",
47+ _"Start collecting basic building materials, and fortify the camp."
48+ .. paragraphdivider() ..
49+ listitem_bullet(_"Build a lumberjack’s hut") ..
50+ listitem_bullet(_"Build a ranger’s hut") ..
51+ listitem_bullet(_"Build a quarry") ..
52+ listitem_bullet(_"Build a wood hardener") ..
53+ listitem_bullet(_"Build a sentry on the eastern border") ..
54+ listitem_arrow(_"You should eventually also build a reed yard and a lime kiln."))
55+}
56+
57 obj_build_small_food_economy = {
58 name = "build_small_food_economy",
59 title = _"Build up a small food economy",
60@@ -149,6 +164,7 @@
61 .. paragraphdivider() ..
62 -- TRANSLATORS: Thron
63 _([[For now, we are resting at the borders of the old forest and preparing for the coming days.]]))
64+ .. new_objectives(obj_build_basic_economy)
65 }
66
67 story_msg_2 = {

Subscribers

People subscribed via source and target branches

to status/vote changes: