Code review comment for lp:~widelands-dev/widelands-website/pagination

Revision history for this message
GunChleoc (gunchleoc) wrote :

I am getting 2 warning during pip install -r pip_requirements.txt. Feel free to have a look in a separate branch.

  Cloning git://github.com/zyga/django-pagination.git (to 86caf150984733eb5a0bb07af26cd8fc0a8d8496) to /home/bratzbert/widelands-website/wlwebsite/src/linaro-django-pagination
  Could not find a tag or branch '86caf150984733eb5a0bb07af26cd8fc0a8d8496', assuming commit.

And unrelated to this particular branch:
  Cloning git://github.com/kerin/django-sphinx.git (to 1c5ef8abcf86f9a9458f763ceb9e5d882247ea37) to /home/bratzbert/widelands-website/wlwebsite/src/django-sphinx
  Could not find a tag or branch '1c5ef8abcf86f9a9458f763ceb9e5d882247ea37', assuming commit.

I wanted to do a bit of testing, but it would take too long go create content, so I'll just assume that you have tested it well. Code LGTM.

review: Approve

« Back to merge proposal