Code review comment for lp:~widelands-dev/widelands-website/notifications_cleanup

SirVer (sirver) wrote :

I think your reasoning and arguments are correct. My thoughts are more like this: Using django's ORM makes the schema of your messages explicit in the code (as compared to pickling them) and allows for transformations forward of the schema (using south). It is also resilient to updates of django and allows for quicker access and filtering (through the database).

It just seems interesting that they decided to pickle them instead. It just seems the wrong decision to me. But in our case I do not expect problems with either approach anyways.

« Back to merge proposal