Code review comment for lp:~widelands-dev/widelands-website/add_ops

Revision history for this message
SirVer (sirver) wrote :

kaputtnik, I know where you are coming from - I also preferred having source and tools separate before - it just feels cleaner. I came to the conclusion though that it is easier and preferable to keep the ops tools with the source code. It makes the audit trail easier (i.e. which scripts get run and when) and the scripts are consistently used and developed - independent of who is working on the server. It is a sort of runnable documentation.

I think the alias is hard to maintain and enforce - I guess we just have to remember that we have an ops script for this.

> Why not create a cron job for this?

apt-get update's can fail and/or query for decisions. An admin needs to make the calls there (which usually are: keep the config files that are in place and/or reload all services). I prefer doing this manually - I do it every 30 days.

> Re: Maintenance site

I wrote semi complex upstart scripts for the website and alpha (which are run through sudo start wlwebsite). We could change these to start the maintenance site instead. I think these upstart scripts should also be checked in and the ones in /etc/init/* should be symlinks the ones in the repository. This is also ops, of course.

« Back to merge proposal