Code review comment for lp:~widelands-dev/widelands-website/add_DISPLAY_to_update_help

Revision history for this message
kaputtnik (franku) wrote :

> Agreed - ron the normpath ove it at the place that it is built if possible

Hm, i don't know... running normpath over each path constant after it has been build?:

bd = "/path/to/some/thing/"
MEDIA = bd + "/extended/path/"
MEDIA = os.path.normpath(MEDIA)

Looks like the programmer doesn't trust himself :-D

> I don't think we really need an automatic update here - this data doesn't
> change very often. Maybe as a wishlist bug?

I have added a task for updating the encyclopedia to https://wl.widelands.org/wiki/ReleasingWidelands/

Nevertheless we should have a hint for the DISPLAY problem. The easiest way would be to modify the error message from:

"Error: Unable to execute 'wl_map_object_info' for generating the JSON files."

to:

"Error: Unable to execute 'wl_map_object_info' for generating the JSON files. Have you exported DISPLAY = ':1' before running update_help?"

« Back to merge proposal