Code review comment for lp:~whosdaz/ubuntu-qa-website/ubuntu-font-tweak

Revision history for this message
Steve Langasek (vorlon) wrote :

Hi Matthew,

Apologies that this MP was never reviewed!

I'm in the process of preparing to migrate this repository from bzr to git, which means checking for outstanding MPs.

Unfortunately, I don't think I want to merge this as-is, as it introduces a dependency on a third-party website (fonts.googleapis.com) into the code.

I would really prefer to be able to just include https://assets.ubuntu.com/v1/vanilla-framework-version-1.8.0.min.css which is the standard style sheet for Ubuntu websites, but it doesn't play well with drupal assumptions about the markup.

So instead I have extracted the font handling from that stylesheet, and committed the change to the site; you should be able to see it live now on https://iso.qa.ubuntu.com/.

If you have any further suggestions for improvement (... seven years later), feel free to submit them against the git repository which will be live shortly!

review: Disapprove

« Back to merge proposal