Code review comment for lp:~whosdaz/ubuntu-html5-theme/fixtypog

Revision history for this message
Matthew Allen (whosdaz) wrote :

Hey,
Will do when I'm home - is that all?
Is the task approved after that?

On 18 Dec 2015 8:06 pm, "Alexandre Abreu" <email address hidden>
wrote:
>
> Hi,
>
> just remove it :)
> the only necessary iframe is the widgets.hml one
>
> On Thu, Dec 17, 2015 at 9:36 PM, MatthewAllen <email address hidden> wrote:
>
> > > Could you remove the "<iframe src="../widgets/Toggles.htm" in
> > > examples/html5-theme/ui-gallery/index.html ?
> > >
> > > I added a few inline comments below,
> >
> > What should the iFrame be changed to?
> > As I assume the frame itself needs to stay in the page??? As that's
what's
> > used to see each page???
> > --
> >
> >
https://code.launchpad.net/~whosdaz/ubuntu-html5-theme/fixtypog/+merge/280859
> > You are reviewing the proposed merge of
> > lp:~whosdaz/ubuntu-html5-theme/fixtypog into lp:ubuntu-html5-theme.
> >
>
> --
>
https://code.launchpad.net/~whosdaz/ubuntu-html5-theme/fixtypog/+merge/280859
> You are the owner of lp:~whosdaz/ubuntu-html5-theme/fixtypog.

« Back to merge proposal