Do

Code review comment for lp:~whatah/do/keybindings

Revision history for this message
Alex Launi (alexlauni) wrote :

There is still whitespace issues in a bunch of the files, this needs cleared up, but can be done easily in vim. If you're using monodevelop, this is why. MD does weird stuff with whitespace.

line 104 in KeyBindingTreeView.cs, you should turn that anonymous function into a real function. It'll make the code cleaner, it's confusing to see a return statement in the middle of another function.

In the same file, can you localize the column headers?

You mix { placement styles, in some places you do
foreach (...)
{
in others you do
foreach (...) {

use the latter. The same for if statements.

Does the keybinding class need an initialize method? Can the stuff in the init method actually go in the constructor?

« Back to merge proposal