Snapcraft

~wgrant/snapcraft/+git/github:spec-pr-typo

  1. Git
  2. lp:~wgrant/snapcraft/+git/github
  3. spec-pr-typo
Last commit made on 2020-08-14
Get this branch:
git clone -b spec-pr-typo https://git.launchpad.net/~wgrant/snapcraft/+git/github

Branch merges

Branch information

Name:
spec-pr-typo
Repository:
lp:~wgrant/snapcraft/+git/github

Recent commits

347f29a... by Chris Patterson

specifications: fix typo in package-repositories

Signed-off-by: Chris Patterson <email address hidden>

88cc08f... by Chris Patterson

ros2: specification, extension & colcon v2 plugin for core20 (#3203)

Includes specification for documentation purposes.

Signed-off-by: Chris Patterson <email address hidden>
Co-authored-by: Sergio Schvezov <email address hidden>

8328cd9... by Chris Patterson

file utils: introduce get_host_tool_path() to find commands on host (#3244)

A counterpart to get_snap_tool_path() for finding commands inside of
snapcraft snap, this finds tools required on the host.

Raises snapcraft.internal.errors.SnapcraftHostToolNotFoundError if not found.

- Renames HostToolNotFoundError -> SnapcraftHostToolNotFoundError
- Uses this new method for lifecycle finding snapd.
- Update tests (and minor refactor to import 'errors' rather
  than continue cherry-picking each exception import.)

Signed-off-by: Chris Patterson <email address hidden>

9a9eb18... by Chris Patterson

spread tests: fix classic patchelf linker regex to match all arches (#3247)

Fix by broadening the match to ld.*.

Signed-off-by: Chris Patterson <email address hidden>

65a7c63... by Chris Patterson

plugins v2: quote python packages argument for pip (#3246)

If using a python package with conditionals, e.g.:
    python-packages:
      - ibm-db-sa; platform_machine == 'x86_64'
      - ibm-db-sa; platform_machine == 'ppc64le'
      - ibm-db-sa; platform_machine == 's390x'

Then snapcraft would pass the python packages unquoted to pip,
resulting in build errors. Ensure the packages are quoted
safely using shlex.quote() when building the command string.

Update existing python-package spread test and python-package
unit test to cover this case.

LP: #1884429

Signed-off-by: Chris Patterson <email address hidden>

409b8e8... by Chris Patterson

build providers: install apt-transport-https (#3232)

When using package-repositories, additional repositories may
be used that require HTTPS. Install apt-transport-https
as a required package, if not already available.

Signed-off-by: Chris Patterson <email address hidden>

e622647... by Chris Patterson

cli: only issue warning when checking for usage of sudo (#3240)

Signed-off-by: Chris Patterson <email address hidden>

1594cf4... by Chris Patterson

specifications: minor cleanup for package-repositories (#3245)

Add some hints based off feedback from users and tidy
up some formatting.

Signed-off-by: Chris Patterson <email address hidden>

e76a077... by Chris Patterson

tests: migrate legacy classic patchelf tests to spread (#3242)

- Sort the core base rpaths so ordering is predictable.
- Add get_base() to spread helper functions.
- Remove legacy test_stage tests module.

Signed-off-by: Chris Patterson <email address hidden>

be00472... by Chris Patterson

extensions: add experimental extension support

- Add is_experimental() interface to extension to
  allow extension to indicate it is experimental, conditional
  to the base.

- Require --enable-experimental-extensions for user to
  acknowledge unstable extension usage.

- Raise (new) SnapcraftExperimentalExtensionsRequiredError
  if user configures an experimental extension without the
  --enable-experimental-extensions flag.

Signed-off-by: Chris Patterson <email address hidden>