Spread tests should capture any missing tools from the snap,
should we make that mistake. If the host is missing the tool,
do not offer to report it to sentry.
Fixes SNAPCRAFT-1V7
Signed-off-by: Chris Patterson <email address hidden>
review tools: link or copy snap to snap common (#3220)
Attempt to link and then copy the snap to review into the review-tools'
SNAP_USER_COMMON area to support the cases where the snap created in an
area the review tools cannot read from or the broader case of having the
"home" interface disconnected.
build providers: tweak environment clean detection and logging (#3216)
This error is often incorrect:
f"Build environment was created with unknown snapcraft version {built_by!r}, cleaning."
Update to more accurately describe that we simply don't know its state:
"Build environment is in unknown state, cleaning first."
For consistency, also reword the following by specifying "first":
(2) f"Project base changed from {provider_base!r} to {build_base!r}, cleaning build instance."
-> f"Project base changed from {provider_base!r} to {build_base!r}, cleaning first."
(3) f"Build environment was created with newer snapcraft version {built_by!r}, cleaning."
-> f"Build environment was created with newer snapcraft version {built_by!r}, cleaning first."
Pull these checks into new function '_check_environment_needs_cleaning()',
so there is only one call to clean_project().
Signed-off-by: Chris Patterson <email address hidden>
cli: use prefix in store name registration hint (#3213)
Snapcraft recommended to register <snap-name>-<username> to overcome
concerns about ownership of a given name. It was agreed a while ago to
prefix the username suggestion to have a common namespace for a
publisher for ordering/listing.
