Merge lp:~wgrant/launchpad/purge-more-password into lp:launchpad

[William Grant]

Drop a few more unused password-related bits and pieces from around the tree.

Drop a few more unused password-related bits and pieces from around the tree.

[William Grant (wgrant)]

review: Approve (code)

=== modified file 'lib/lp/app/validators/validation.py'
--- lib/lp/app/validators/validation.py	2012-01-17 03:49:38 +0000
+++ lib/lp/app/validators/validation.py	2012-01-25 09:58:30 +0000
@@ -12,7 +12,6 @@
     'valid_cve_sequence',
     'validate_new_team_email',
     'validate_new_person_email',
-    'valid_password',
     'validate_date_interval',
     ]
 
@@ -132,38 +131,6 @@
     return True
 
 
-def valid_password(password):
-    """Return True if the argument is a valid password.
-
-    A valid password contains only ASCII characters in range(32,127).
-    No ASCII control characters are allowed.
-
-    password that contains only valid ASCII characters
-    >>> valid_password(u"All ascii password with spaces.:\\&/")
-    True
-
-    password that contains some non-ASCII character (value > 127)
-    >>> valid_password(u"password with some non-ascii" + unichr(195))
-    False
-
-    password that contains ASCII control characters (0 >= value >= 31)
-    >>> valid_password(u"password with control chars" + chr(20))
-    False
-
-    empty password.
-    >>> valid_password(u"")
-    True
-
-    """
-    assert isinstance(password, unicode)
-    valid_chars = [chr(x) for x in range(32, 127)]
-    invalid = set(password) - set(valid_chars)
-    if invalid:
-        return False
-    else:
-        return True
-
-
 def validate_date_interval(start_date, end_date, error_msg=None):
     """Check if start_date precedes end_date.
 
 
=== modified file 'lib/lp/services/fields/__init__.py'
--- lib/lp/services/fields/__init__.py	2012-01-01 02:58:52 +0000
+++ lib/lp/services/fields/__init__.py	2012-01-25 09:58:30 +0000
@@ -21,7 +21,6 @@
     'IDescription',
     'ILocationField',
     'INoneableTextLine',
-    'IPasswordField',
     'IPersonChoice',
     'IStrippedTextLine',
     'ISummary',
@@ -37,7 +36,6 @@
     'MugshotImageUpload',
     'NoneableDescription',
     'NoneableTextLine',
-    'PasswordField',
     'PersonChoice',
     'PillarAliases',
     'PillarNameField',
@@ -81,7 +79,6 @@
     Field,
     Float,
     Int,
-    Password,
     Text,
     TextLine,
     Tuple,
@@ -94,7 +91,6 @@
     IField,
     Interface,
     IObject,
-    IPassword,
     IText,
     ITextLine,
     )
@@ -152,11 +148,6 @@
     """A field that allows entry of a Bug number or nickname"""
 
 
-class IPasswordField(IPassword):
-    """A field that ensures we only use http basic authentication safe
-    ascii characters."""
-
-
 class IAnnouncementDate(IDatetime):
     """Marker interface for AnnouncementDate fields.
 
@@ -418,17 +409,6 @@
             return super(SearchTag, self).constraint(value)
 
 
-class PasswordField(Password):
-    implements(IPasswordField)
-
-    def _validate(self, value):
-        # Local import to avoid circular imports
-        from lp.app.validators.validation import valid_password
-        if not valid_password(value):
-            raise LaunchpadValidationError(_(
-                "The password provided contains non-ASCII characters."))
-
-
 class UniqueField(TextLine):
     """Base class for fields that are used for unique attributes."""
 
 
=== modified file 'lib/lp/services/verification/interfaces/authtoken.py'
--- lib/lp/services/verification/interfaces/authtoken.py	2012-01-05 00:23:45 +0000
+++ lib/lp/services/verification/interfaces/authtoken.py	2012-01-25 09:58:30 +0000
@@ -29,7 +29,6 @@
     )
 
 from lp import _
-from lp.services.fields import PasswordField
 
 
 class LoginTokenType(DBEnumeratedType):
@@ -174,10 +173,6 @@
     # used for launchpad page layout
     title = Attribute('Title')
 
-    # Quick fix for Bug #2481
-    password = PasswordField(
-        title=_('Password'), required=True, readonly=False)
-
     def consume():
         """Mark this token as consumed by setting date_consumed.
 
@@ -188,13 +183,3 @@
 
     def sendEmailValidationRequest():
         """Send an email message with a magic URL to validate self.email."""
-
-    def sendPasswordResetEmail():
-        """Send an email message to the requester with a magic URL that allows
-        him to reset his password.
-        """
-
-    def sendNewUserEmail():
-        """Send an email message to the requester with a magic URL that allows
-        him to finish the Launchpad registration process.
-        """