Code review comment for lp:~wgrant/launchpad/product-index-code-stab

To my eye there seems to be a bit of missing spacing above "Version control system" relative to other similar things on the page. Presumably this has something to do with the default CSS for .two-column-list dl:first-child dt, so maybe style="margin-top 0.5em;" there would help.

I can see why you put the questions portlets on the LHS, but I'm not sure I like it. Having them more or less diagonally opposite bugs looks kind of odd, since they're listed in a similar style. Also, putting them on the LHS seems more prominent than they typically deserve; when skimming a page I find my eye scans down the LHS first rather than going across to the middle. And FAQs below questions makes no logical sense at all, since if we have FAQs at all they should appear earlier in the page flow. Perhaps:

  Code FAQs
  Bugs Questions
  Packages Specs
  Contributors Sprints

... would be reasonably balanced? Most common collaboration targets at the top left; FAQs above questions; LHS should I think usually come out similar height or slightly higher.

Another logical layout would be more developer-centric stuff on one side, more user-centric stuff on the other. That would yield something like:

  Code Packages
  Specs Bugs
  Sprints FAQs
  Contributors Questions

But I'm not convinced that's better, and it might need to be flipped left to right in order to avoid the RHS typically being longer, which decreases the prominence of Code too much for my taste.

The actual patch looks fine, and I definitely like the revamped Code layout; so whatever you pick out of these or your existing layout is OK, and we can always adjust things further later.