Code review comment for lp:~wgrant/launchpad/flatten-bfj-3.5-more-query

115 + store = getUtility(IStoreSelector).get(MAIN_STORE, DEFAULT_FLAVOR)

I know this code is copied, but IStore? Please?

129 + if status is None or status in unfinished_states:
130 + result_set.order_by(
131 + Desc(BuildFarmJob.date_created), BuildFarmJob.id)
132 + else:
133 + result_set.order_by(
134 + Desc(BuildFarmJob.date_finished), BuildFarmJob.id)

Personally, I'd prefer setting an order array, and then returning store.find().order_by(*order), but eh.

703 # Until we have different IBuildFarmJob types implemented, we
704 # can only test this by creating a lone PackageBuild of a
705 # different type.

Now hysterical raisins, so delete it.

716 # different type.

A copy of the same comment from above?

749 - buildfarmjob_ids = [buildfarmjob.id for buildfarmjob in buildfarmjobs]

Haha, even above the docstring. Good work killing it.