Code review comment for lp:~wgrant/launchpad/flatten-bfj-0-db

Revision history for this message
Stuart Bishop (stub) wrote :

You need indexes on all of the log and upload_log columns or the Librarian Garbage Collector will hate you. This will need to be landed separately and applied live straight after, as there are a several million existing rows.

You can't default date_created and failure_count columns when creating the column without rewriting the entire tables and their indexes. Add the DEFAULTs using separate ALTER TABLE statements and you will be fine.

review: Approve (db)

« Back to merge proposal