Code review comment for lp:~wgrant/launchpad/fix-ajax-subscription-bug-415166

Revision history for this message
Henning Eggers (henninge) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
thanks for fixing this bug which just bit me this morning and I thought
"I ought to file a bug for this." And there you come along with a fix
already. Great!

I also like your fix very much, especially fixing the test to not rely
on (kind of) random numbers is much appreciated.

So, nothing I can find to complain about ;-), this branch is good to land.

 review: approve

Cheers,
Henning
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqKX/gACgkQBT3oW1L17ihcFgCdELSgLqw0uRwR2eprULotwQDJ
OFAAnA8N+1awSiti8o/JkRwbhC6Rpdnx
=1AgZ
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal