Code review comment for lp:~wgrant/launchpad/ddeb-domination

Hi William,

This is a very good change! At first I was caught thinking testJudgeAndDominateWithDDEBs() needed refactoring, but was pleasantly surprised to find that you fully tested both DDEB policies in the test_publishing module. I guess testJudgeAndDominate is just checking that the components are integrated correctly.

The only other question is about _getCorrespondingDDEBPublications(): can it use the ISlaveStore instead of the IMasterStore? Check lib/canonical/launchpad/doc/db-policy.txt for the difference.

Otherwise this looks good to me: r=mars

Maris