Code review comment for lp:~wgrant/launchpad/bug-708999-ff-docs

On 17 February 2011 03:16, Aaron Bentley <email address hidden> wrote:
> I fully agree that we need a standard way of doing boolean FeatureFlags.  I believe the lack of it indicates that Feature Flags are incomplete, since enabling/disabling features was described as key functionality.
>
> But I think using empty/non-empty to indicate boolean is pretty gross.

I think it's gross too. I filed
<https://bugs.launchpad.net/launchpad/+bug/719182> for that. I think
documenting what currently exists has some value, and making things
consistent also. I'm not really happy about making them consistent
with the worst precedented approach, but doing it one step at a time
is good too.