Merge lp:~wgrant/launchpad/bug-680889-arch-wildcards into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Henning Eggers |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12029 |
Proposed branch: | lp:~wgrant/launchpad/bug-680889-arch-wildcards |
Merge into: | lp:launchpad |
Diff against target: |
291 lines (+121/-131) 3 files modified
lib/lp/soyuz/doc/package-arch-specific.txt (+0/-116) lib/lp/soyuz/pas.py (+22/-15) lib/lp/soyuz/tests/test_pas.py (+99/-0) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/bug-680889-arch-wildcards |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Henning Eggers (community) | code | Approve | |
Review via email: mp+42723@code.launchpad.net |
Commit message
[r=henninge]
Description of the change
As reported in bug #680889, lp.soyuz.
It's a pretty simple change, except that I had to move the "all" check to the end, so hint strings like "all amd64" create an amd64 build, not an i386 arch-indep one.
I extended the tests to cover the specific problem reported and a few other edge cases.
Hi William,
thanks for this fix. The code looks good to me with my limited domain knowledge. ;-) I am worried about the doc test growing out of proportion, though, as it covers more corner cases. I would think these should be tested in a unit test while the doctest just shows the general operation of the code. Could you do something along those lines, please?
Cheers,
Henning