Merge lp:~wgrant/launchpad/bug-677270 into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Merged at revision: | 17866 |
Proposed branch: | lp:~wgrant/launchpad/bug-677270 |
Merge into: | lp:launchpad |
Diff against target: |
152 lines (+57/-8) 3 files modified
lib/lp/services/librarian/client.py (+6/-3) lib/lp/services/librarianserver/db.py (+20/-2) lib/lp/services/librarianserver/tests/test_web.py (+31/-3) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/bug-677270 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+279974@code.launchpad.net |
Commit message
Canonicalise path encoding before checking a librarian TimeLimitedToken.
Description of the change
Canonicalise path encoding before checking a librarian TimeLimitedToken, and leave tildes unescaped in librarian URLs to appease RFC 3986 and Chromium.
I'm also tempted to whitelist +, as it has no special meaning in the path. Thoughts welcome.
To post a comment you must log in.
IRC discussion has convinced me that we should whitelist +; doing so is harmless and would probably make e.g. dget behave more gracefully. Otherwise this looks good to me.