Launchpad itself

Merge lp:~wgrant/launchpad/bug-607954 into lp:launchpad

  1. bug-607954
  2. Merge into devel
Proposed by William Grant
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 12611
Proposed branch: lp:~wgrant/launchpad/bug-607954
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~wgrant/launchpad/bug-607954
Reviewer Review Type Date Requested Status
Steve Kowalik (community) Approve
Review via email: mp+53567@code.launchpad.net

Commit message

[r=stevenk][bug=607954] Prevent several queries from being issued for each diff shown on DistributionSourcePackage:+changelog

Description of the change

DistributionSourcePackage:+changelog loads all relevant PackageDiffs and then goes on to show their titles. But this calculation requires both involved SPRs, their upload archives, their distributions, and the diff's library file. Only the library files are problematic at the moment, since the page already has most of the other data. This will change once derivation is in use, and we have inter-distro SPRs and diffs.

To post a comment you must log in.
Revision history for this message
Steve Kowalik (stevenk) wrote :

This looks good. I have asked William to add a comment on the change to use set() in the bulk loader.

review: Approve

Preview Diff

Empty