timeout on DistributionSourcePackage:+changelog

This page already had lots of love - changelog used to be on the DSP index but I moved it out as it's very costly to render. However, the distro guys insist on keeping the whole changelog on a single page so that they can use ctrl-f in the browser to search for stuff.

So, we need to make it searchable somehow before we can do anything about this.

Having said that, I'm surprised it's using so much SQL time. Most of the slowness should be in rendering the huge page.

Ah, it's because it's issuing hundreds of queries trying to linkify bug numbers and email addresses. This is extremely hard to fix because the changelog is not a single file, but rather lots of entries from all the sourcepackagerelease rows, which makes it harder to collate all the bug numbers / email addresses and issue a mass query.

Why does it need to make a query for each bug number? I thought we stopped putting the summary in a tooltip.

On Wednesday 21 July 2010 12:25:04 you wrote:
> Why does it need to make a query for each bug number? I thought we
> stopped putting the summary in a tooltip.

So if it knows if the bug is a valid number before linking. We could just
link blindly but that has the potential to raise the OOPS count.

That seems pretty trivial:
1) gather all the bug numbers we want to check
2) do a single query checking which ones exist
3) linkify to the /bugs/XXX links.

Likewise people.

Or am I missing something?

-Rob

Yes :)

The way the page is rendered makes that hard as it loops over all the SPRs in tal (to repeat each rendered section for each SPR).

Ugh. Ok, so:
a view that gets all the sprs and DTRT
talk talks to the view
?

On Wednesday 21 July 2010 19:52:29 you wrote:
> Ugh. Ok, so:
> a view that gets all the sprs and DTRT
> talk talks to the view
> ?

I'm sure something can be done, it's just not as trivial as some query
optimisations... :(

Just got one of firefox:
OOPS-1857D776
https://launchpad.net/ubuntu/+source/firefox/+changelog

Fixed in stable r12611 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12611>.

https://qastaging.launchpad.net/ubuntu/+source/glib2.0/+changelog timed out - OOPS-1901QS218

OOPS-1901QS219

Rendered third time - 91 queries/external actions issued in 4.61 seconds. So it can perform ok, but we've plenty of room to improve.