Merge lp:~wgrant/launchpad/anonymous-irc-nicks-and-wiki-names into lp:launchpad

[William Grant]

Allow anonymous API clients to list a person's IRC nicks and wiki names.

The trivial addition of two AnonymousAuthorization derivatives for a person's IRC IDs and wiki names, and similarly trivial tests. This lets anonymous API clients list the objects.

[Guilherme Salgado (salgado)]

Looks good to me.

review: Approve (code)

=== modified file 'lib/canonical/launchpad/security.py'
--- lib/canonical/launchpad/security.py	2010-03-10 23:20:31 +0000
+++ lib/canonical/launchpad/security.py	2010-03-12 09:09:18 +0000
@@ -86,6 +86,8 @@
 from lp.registry.interfaces.productseries import IProductSeries
 from lp.registry.interfaces.projectgroup import (
     IProjectGroup, IProjectGroupSet)
+from lp.registry.interfaces.irc import IIrcID
+from lp.registry.interfaces.wikiname import IWikiName
 from lp.code.interfaces.seriessourcepackagebranch import (
     IMakeOfficialBranchLinks, ISeriesSourcePackageBranch)
 from lp.registry.interfaces.sourcepackage import ISourcePackage
@@ -2234,6 +2236,14 @@
             account)
 
 
+class ViewIrcID(AnonymousAuthorization):
+    usedfor = IIrcID
+
+
+class ViewWikiName(AnonymousAuthorization):
+    usedfor = IWikiName
+
+
 class EditArchivePermissionSet(AuthorizationBase):
     permission = 'launchpad.Edit'
     usedfor = IArchivePermissionSet
 
=== modified file 'lib/lp/registry/stories/webservice/xx-person.txt'
--- lib/lp/registry/stories/webservice/xx-person.txt	2010-02-24 16:53:30 +0000
+++ lib/lp/registry/stories/webservice/xx-person.txt	2010-03-12 09:09:18 +0000
@@ -371,6 +371,11 @@
     >>> print_self_link_of_entries(webservice.get(wikis_link).jsonBody())
     http://.../~salgado/+wikiname/2
 
+They can be listed by anonymous clients.
+
+    >>> print_self_link_of_entries(anon_webservice.get(wikis_link).jsonBody())
+    http://.../~salgado/+wikiname/2
+
 Wiki names are first-class objects with their own URLs and
 representations too.
 
@@ -457,6 +462,11 @@
     >>> print_self_link_of_entries(webservice.get(irc_ids_link).jsonBody())
     http://.../~mark/+ircnick/1
 
+Anonymous listing is possible.
+
+    >>> print_self_link_of_entries(anon_webservice.get(irc_ids_link).jsonBody())
+    http://.../~mark/+ircnick/1
+
 IRC IDs are first-class objects with their own URLs and representations
 too.