Code review comment for lp:~weyrick/bzr/54624-warn-on-large-files

Hi Jonathan,

I think your second comment is solved by the first. By that I mean, I
believe if you specify the file on the command line, it should never
be skipped because it's large because that's never what you'd want
(actually maybe a tab completion mistake, but that's not likely
enough). Therefore, an effective way to force adding a large file is
simply to specify it on the command line.

So if you had said "bzr add ." and it told you it skipped a few files,
you could follow it up with "bzr add foo bar" to get the large ones
you really wanted. Seems like a decent work flow to me, and solves the
problem of accidentally adding large files during a recursive import,
while still allowing flexibility with both the config option and the
explicit adds.

Shannon

On Wed, Aug 17, 2011 at 7:41 AM, Jonathan Riddell <email address hidden> wrote:
> Review: Needs Fixing
> Unfortunately this doesn't work if you specify the file name on the bzr add command, in this case the code path seems to go through mutabletree.py  _SmartAddHelper._add_one_and_parent().
>
> Also I think there should be a command line way to force adding large files (although that don't need to be part of this patch).
>
> --
> https://code.launchpad.net/~weyrick/bzr/54624-warn-on-large-files/+merge/70691
> You are the owner of lp:~weyrick/bzr/54624-warn-on-large-files.
>