Code review comment for lp:~wesmason/charms/trusty/conn-check/trunk-fix-perms

Revision history for this message
Michael Nelson (michael.nelson) wrote :

20:48 < noodles> wes: I still don't understand why you don't just do nagios:nagios for those perms?
20:49 < noodles> Why do the "run check" and "run nagios checks" tasks need a separate user?
20:50 < wes> noodles: I don't think they do, although I am uneasy about creating/updating the user in the conn-check charm which may be created/updated differently in the nrpe charm
20:51 -!- noise [<email address hidden>] has quit [Ping timeout: 121 seconds]
20:52 < noodles> wes: why would you create/update the user?
20:52 < noodles> Don't those tasks specifically run after the nagios user will already be created?
20:53 < wes> noodles: nope, as it's not guaranteed you're using nagios with the charm
20:54 < noodles> OK, makes sense.

review: Approve

« Back to merge proposal