Merge lp:~wenchien/ubiquity/precise-proposed.lp944614 into lp:~ubuntu-installer/ubiquity/precise-proposed

Proposed by Jesse Sung
Status: Rejected
Rejected by: Dimitri John Ledkov
Proposed branch: lp:~wenchien/ubiquity/precise-proposed.lp944614
Merge into: lp:~ubuntu-installer/ubiquity/precise-proposed
Diff against target: 11 lines (+1/-1)
1 file modified
ubiquity/plugins/ubi-console-setup.py (+1/-1)
To merge this branch: bzr merge lp:~wenchien/ubiquity/precise-proposed.lp944614
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Disapprove
Colin Watson (community) Disapprove
Review via email: mp+143251@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

I feel this needs more investigation for the same reason as:

  https://code.launchpad.net/~wenchien/ubiquity/ubiquity.lp944614/+merge/143250

review: Disapprove
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Stgraber wrote in the other proposal:
"I believe the right way to fix this bug is to cancel the timeouts when moving away from the page.
I pushed a change doing that to trunk and confirmed that it fixes the bug."

review: Disapprove

Unmerged revisions

5430. By Jesse Sung

Make sure dbfilter is not None before using it. (LP: #944614)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubiquity/plugins/ubi-console-setup.py'
2--- ubiquity/plugins/ubi-console-setup.py 2012-03-27 00:15:43 +0000
3+++ ubiquity/plugins/ubi-console-setup.py 2013-01-15 08:53:43 +0000
4@@ -134,7 +134,7 @@
5 def keyboard_variant_timeout(self, *args):
6 layout = self.get_keyboard()
7 variant = self.get_keyboard_variant()
8- if layout is not None and variant is not None:
9+ if layout is not None and variant is not None and self.controller.dbfilter is not None:
10 self.controller.dbfilter.apply_keyboard(layout, variant)
11 return False
12

Subscribers

People subscribed via source and target branches