Code review comment for lp:~wallyworld/launchpad/vouchers-timeout-1014641

Revision history for this message
Curtis Hovey (sinzui) wrote :

Remove the submit-twice-error you added to lib/lp/registry/doc/commercialsubscription.txt because you wrote a unit test for it.

I see the template is doing python evaluation twice to chose true ans false outcomes
    condition="python: vouchers or view_errors"
This check (or both) can be moved into the view so that python: is not used in TAL where is it doing late compilation.

review: Approve (code)

« Back to merge proposal