Code review comment for lp:~wallyworld/launchpad/rename-private-team-795771
Revision history for this message
| Ian Booth (wallyworld) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On 25/08/11 00:53, Curtis Hovey wrote:
> Review: Needs Fixing test
> I am very wary of converting stories into unittests. Most are predicated on issues
> that are relevant. A story only needs to show the happy path that demonstrates
> that the user can perform a goal. In this case I believe only one browser test
> is needs to show that a user can navigate from the team page to the edit page
> and submit a change to be returned to the team page.
>
> Do not use TestBrowser (an integration test) to test what a view
> does (unittest). Browser tests do not document form contracts or directly
> exercise the lines in the view it claims to be testing.
>
I used the browser because I needed the end-end behaviour to test the
saving of a private team as requested in a review comment. The other
uses were from porting the story code and I didn't know how to do it
using the view. Many thanks for providing the examples to show how.