On 02/02/11 10:43, Steve Kowalik wrote:
> Review: Approve code*
> This looks okay to me, aside from a few blank lines that look to have crept -- however, if make lint disagrees with me, then I'll let that slide.
>
Lint is happy - just complains about lines too long which were already
there, related to string literals in some tests.
> Why are the imports for lp.testing.factory right under the docstring rather than being ordered with the rest of them?
>
Cause I need my eyesight checked. Fixed.
> I'd suggest running utilites/format-imports over the files you changed.
On 02/02/11 10:43, Steve Kowalik wrote:
> Review: Approve code*
> This looks okay to me, aside from a few blank lines that look to have crept -- however, if make lint disagrees with me, then I'll let that slide.
>
Lint is happy - just complains about lines too long which were already
there, related to string literals in some tests.
> Why are the imports for lp.testing.factory right under the docstring rather than being ordered with the rest of them?
>
Cause I need my eyesight checked. Fixed.
> I'd suggest running utilites/ format- imports over the files you changed.