Code review comment for lp:~wallyworld/launchpad/recipe-find-related-branches

Revision history for this message
Ian Booth (wallyworld) wrote :

Code changes made to move core model functionality to the IBranchTarget implementation. The View calls through to this class to get the required data. Separate tests written for IBranchTarget. The ordering of related branches is such the those for the most recent product series or distro series appear first. The sorting was done using sorted_version_numbers()

The related package branch listing now shows the distro series instead of the source package. I would appreciate a careful review of the algorithm used to load the related branches (especially the related package branches) to ensure everything is correct.

One question - I don't like it how the related branches tables are inside the form but I think it looks weird if they are moved outside the form and hence appear below the Update Recipe button. I'll do whatever is deemed best.

« Back to merge proposal